Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for resources.arsc parsing #22

Merged
merged 21 commits into from
Jul 24, 2024
Merged

Adds support for resources.arsc parsing #22

merged 21 commits into from
Jul 24, 2024

Conversation

garanj
Copy link
Collaborator

@garanj garanj commented May 23, 2024

Adds handling for release APKs where Android Resources are obfuscated.

Updates tests to test with obfuscated APKs
Adds test to ensure non-obfuscated APKs are also tested

@garanj garanj requested a review from robcos May 23, 2024 13:32
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robcos robcos assigned robcos and unassigned robcos Jun 17, 2024
@robcos robcos requested a review from lucianbc June 17, 2024 09:52
Copy link
Collaborator

@robcos robcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should wait for this until we have tests. Too invasive

amoledwatchfaces and others added 14 commits July 17, 2024 14:22
Added ✅ PASSED / ❌ FAILED to the validator tool output
* Create a new workflow for the release tagged as "release"

The release tagged as "release" is meant to contain the artifacts that should be used
in the validation pipeline at the current moment. It differs from "latest",
which is built automatically and might contain changes that we do not want
to be used for now.

To create a new release, the new workflow must be triggered manually
with the git sha of the commit from where we want to build the artifacts.

The artifacts will be available on the following permalink:
```
https://github.com/{owner}/{repo}/releases/download/{release-name}/{artifact-name}
```
Modify the GitHub action config to use the gradle version used while developing, via the gradle wrapper, rather than setting a hardcoded version in the CI config, that is different than what is used while developing.
Import the existing tests for the memory footprint tool.
# Conflicts:
#	play-validations/memory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/InputPackage.java
Include the analog hands when used with the AnalogClock element in the active calculation.
@garanj
Copy link
Collaborator Author

garanj commented Jul 17, 2024

I think we should wait for this until we have tests. Too invasive
👍 Tests are now passing for obfuscated APKs, non-obfuscated APKs and bundles.

Copy link
Member

@lucianbc lucianbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until we address loading the assets into memory before merging this

@garanj
Copy link
Collaborator Author

garanj commented Jul 23, 2024

Let's wait until we address loading the assets into memory before merging this

Thanks, I've moved to a streamed approach.

@garanj garanj requested a review from lucianbc July 24, 2024 10:44
@lucianbc
Copy link
Member

Let's wait until we address loading the assets into memory before merging this

Thanks, I've moved to a streamed approach.

Looks good to me, but I noticed that with this change, some other code can go away. Once that is gone, this can be merged.

@garanj
Copy link
Collaborator Author

garanj commented Jul 24, 2024

Let's wait until we address loading the assets into memory before merging this

Thanks, I've moved to a streamed approach.

Looks good to me, but I noticed that with this change, some other code can go away. Once that is gone, this can be merged.

Thanks, done!

@garanj garanj requested a review from lucianbc July 24, 2024 15:45
@garanj garanj merged commit e6849ed into main Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants