-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for resources.arsc parsing #22
Conversation
...ations/memory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/ArscResource.java
Outdated
Show resolved
Hide resolved
...lidations/memory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/ArscTable.java
Outdated
Show resolved
Hide resolved
...lidations/memory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/ArscTable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...lidations/memory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/ArscTable.java
Outdated
Show resolved
Hide resolved
...lidations/memory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/ArscTable.java
Outdated
Show resolved
Hide resolved
...lidations/memory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/ArscTable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should wait for this until we have tests. Too invasive
...ations/memory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/ArscResource.java
Outdated
Show resolved
Hide resolved
Added ✅ PASSED / ❌ FAILED to the validator tool output
* Create a new workflow for the release tagged as "release" The release tagged as "release" is meant to contain the artifacts that should be used in the validation pipeline at the current moment. It differs from "latest", which is built automatically and might contain changes that we do not want to be used for now. To create a new release, the new workflow must be triggered manually with the git sha of the commit from where we want to build the artifacts. The artifacts will be available on the following permalink: ``` https://github.com/{owner}/{repo}/releases/download/{release-name}/{artifact-name} ```
Modify the GitHub action config to use the gradle version used while developing, via the gradle wrapper, rather than setting a hardcoded version in the CI config, that is different than what is used while developing.
Import the existing tests for the memory footprint tool. # Conflicts: # play-validations/memory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/InputPackage.java
Include the analog hands when used with the AnalogClock element in the active calculation.
|
...ons/memory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/AndroidResource.java
Outdated
Show resolved
Hide resolved
...emory-footprint/src/main/java/com/google/wear/watchface/dfx/memory/AndroidResourceTable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait until we address loading the assets into memory before merging this
Thanks, I've moved to a streamed approach. |
...ry-footprint/src/main/java/com/google/wear/watchface/dfx/memory/DrawableResourceDetails.java
Show resolved
Hide resolved
Looks good to me, but I noticed that with this change, some other code can go away. Once that is gone, this can be merged. |
Thanks, done! |
Adds handling for release APKs where Android Resources are obfuscated.
Updates tests to test with obfuscated APKs
Adds test to ensure non-obfuscated APKs are also tested